Ticket #12111 (reopened Bug)
@@usergroup-groupmembership "Show All users" batching broken
Reported by: | dpc22 | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 4.x |
Component: | General | Version: | 4.1 |
Keywords: | users, groups, forqa, patch | Cc: | dpc22 |
Description
@@usergroup-groupmembership allows you to search for users to add to a group.
There is also a "Show All" button which displays the first 20 users, with links to:
1) Further pages each with 20 results
2) A "Show all search results" link.
Unfortunately (1) and (2) are both broken: they return empty sets of results as self.searchResults is initialised to be an empty list and then never updated with a search.
I attach a trivial patch for plone/app/controlpanel/usergroups.py, based on the logic used in other parts of the file. I'm not 100% convinced that this is correct, but it definitely fixes the problem for me.
Attachments
Change History
Changed 5 years ago by dpc22
-
attachment
usergroups.patch
added
comment:1 Changed 4 years ago by kleist
- Status changed from new to confirmed
- Keywords users, groups, forqa, patch added; users groups forqa removed
- Version set to 4.1
- Component changed from Infrastructure to General
comment:2 Changed 3 years ago by maartenkling
Tested patch and worked, its the same way as done in @@usergroup-userprefs
made some changes https://github.com/plone/plone.app.controlpanel/pull/6
comment:3 Changed 3 years ago by maartenkling
- Status changed from confirmed to closed
- Resolution set to fixed
merged
comment:4 Changed 11 months ago by dpc22
- Status changed from closed to reopened
- Resolution fixed deleted
Patch to fix problem with plone.app.controlpanel, usergroups.py