Ticket #13926 (new Bug)
plone.app.caching control panel has pop-ups with no styles if pop-ups disabled via themes
Reported by: | anthonygerrard | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 4.x |
Component: | Unknown | Version: | 4.3 |
Keywords: | Cc: | anthonygerrard |
Description
Plone 4.3.x
- login as site admin
- site setup / themes
- uncheck "Use popup overlays for simple forms"
- save
- site setup / caching
- click advanced settings
- click view/edit on one of the rule sets
Expected:
- no pop-up get taken to form page
Actual
- pop-up without css
Really the problem here is that popupforms.js is nasty. It includes form specific code away from the template file.
There must be a better way to do this. It would probably involve marking anchors that open a pop-up with a specific class, moving form specific code to where the anchors actually are and having popupforms.js look for anchors with that class and enable the pop-up on them.
However the quick fix would be, as plone.app.caching is now part of plone core, to move the javascript in popupforms.js :(
Note: See
TracTickets for help on using
tickets.