Ticket #13389 (closed PLIP: fixed)

Opened 3 years ago

Last modified 12 months ago

Add a field to the site control-panel that allows easy customisation of the logo.

Reported by: martior Owned by:
Priority: minor Milestone: 5.0
Component: General Version: 4.2
Keywords: Cc: cewing, eleddy

Description (last modified by eleddy) (diff)

Proposer: Martin Opstad Reistadbakk (martior)
Seconder: None as yet

Motivation

To let users change the site logo without having to go to the zmi or write a custom theme we will add a field to the site control-panel that allows them to upload a logo.

Assumptions

We asume that people want to change the logo used on their site from the Plone logo to one more appropriate for their site. We also assume that they use one of the default themes, or one that uses the same name for the logo.

Proposal & Implementation

This ticket will take code from existing implementations of similar control panels (see: eastofeaton.logopanel) and include it in plone.app.controlpanel.

Deliverables

What code and documentation needs to be produced? Standard items:

  • Control panel code
  • Unit tests
  • Localization
  • Documentation

Risks

Participants

Martin Opstad Reistadbakk

Progress

Several implementations exist already, this PLIP will integrate that work into the site controlpanel in plone.app.controlpanel.

 https://github.com/eleddy/eastofeaton.logopanel/

Change History

comment:1 Changed 3 years ago by martior

  • Description modified (diff)

comment:2 Changed 3 years ago by kleist

  • Status changed from new to confirmed
  • Component changed from Unknown to General

comment:3 Changed 3 years ago by cewing

I am the one who wrote the initial code for eastofeaton.logopanel. I have core rights and am happy to have the code used. I would also be happy to participate in this PLIP. Count me in

comment:4 Changed 3 years ago by cewing

  • Cc cewing added

comment:5 Changed 3 years ago by eleddy

  • Cc eleddy added

comment:6 Changed 3 years ago by eleddy

The main issue with the current implementation is some weird caching that is happening on the first upload. Other than that I use it in production with no problems. That is my repo so please feel free to use what you need. Will update the description

comment:7 Changed 3 years ago by eleddy

  • Description modified (diff)

comment:8 Changed 3 years ago by eleddy

I moved this repo into the collective so that others can modify it -  https://github.com/collective/eastofeaton.logopanel

comment:9 Changed 3 years ago by esteele

  • Milestone changed from 4.x to 5.0

The Framework Team has decided to move on to Plone 5. Updating milestones accordingly.

comment:10 Changed 17 months ago by jensens

In order to make this feature complete the favicon should be taken into account here too.

comment:12 Changed 12 months ago by jensens

  • Status changed from confirmed to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.