Ticket #13706 (new Bug)

Opened 3 years ago

Last modified 3 years ago

Memory leak in plip13350-edit-member-schema-ttw

Reported by: interra Owned by:
Priority: minor Milestone: 4.x
Component: Unknown Version:
Keywords: Cc:

Description

This bug report applies to  plone.app.users plip13350-edit-member-schema-ttw branch that is dedicated to implementing PLIP #13350. I'm submitting it here since Issues are disabled at Github for plone/plone.app.users repository.

Following script causes Zope instance memory consumption to explode:

export SITE=http://localhost:8080/Plone
while true; do curl --user admin:admin "$SITE/@@personal-information" ; done

Memory consumption of Zope instance should not increase while script is being executed.

We do have fix for the issue and will submit pull request for it.

Change History

comment:1 Changed 3 years ago by davisagli

As far as I can tell, that PLIP needs some pretty major changes so that it doesn't create interfaces and adapters every time the user forms are loaded. I wouldn't recommend using it in its current state.

comment:2 Changed 3 years ago by interra

As I'd written in the description, we do have some fixes in the direction you pointed already. We understand that the current behavior is not desired and implemented simple caching of generated schemas. Additionally we have some achievements to eliminate dynamic adapter registration, but it still has some work to do.

I'll comment here as soon as we have submitted pull request for discussion.

comment:3 Changed 3 years ago by davisagli

Cool, sounds promising. I'd be happy to review the pull request once it's ready.

comment:4 Changed 3 years ago by interra

I've submitted first of the 3 pull requests at  https://github.com/plone/plone.app.users/pull/9.

The other pending are:

They are cumulative, and have to be merged one by one.

Note: See TracTickets for help on using tickets.