Ticket #13539 (confirmed Bug)

Opened 3 years ago

Last modified 2 years ago

Sitmap traceback after migrating 4.2.5 to 4.3

Reported by: AbimAbam Owned by:
Priority: major Milestone: 4.x
Component: Upgrade/Migration Version: 4.3
Keywords: sitemap Cc:

Description (last modified by kleist) (diff)

After upgrading a Plone instance from 4.2.5 to 4.3 /sitemap produces the following traceback:

Traceback (innermost last):
  Module ZPublisher.Publish, line 126, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 46, in call_object
  Module Shared.DC.Scripts.Bindings, line 322, in __call__
  Module Shared.DC.Scripts.Bindings, line 359, in _bindAndExec
  Module Products.CMFCore.FSPageTemplate, line 237, in _exec
  Module Products.CMFCore.FSPageTemplate, line 177, in pt_render
  Module Products.PageTemplates.PageTemplate, line 79, in pt_render
  Module zope.pagetemplate.pagetemplate, line 132, in pt_render
  Module zope.pagetemplate.pagetemplate, line 240, in __call__
  Module zope.tal.talinterpreter, line 271, in __call__
  Module zope.tal.talinterpreter, line 343, in interpret
  Module zope.tal.talinterpreter, line 888, in do_useMacro
  Module zope.tal.talinterpreter, line 343, in interpret
  Module zope.tal.talinterpreter, line 533, in do_optTag_tal
  Module zope.tal.talinterpreter, line 518, in do_optTag
  Module zope.tal.talinterpreter, line 513, in no_tag
  Module zope.tal.talinterpreter, line 343, in interpret
  Module zope.tal.talinterpreter, line 954, in do_defineSlot
  Module zope.tal.talinterpreter, line 343, in interpret
  Module zope.tal.talinterpreter, line 533, in do_optTag_tal
  Module zope.tal.talinterpreter, line 518, in do_optTag
  Module zope.tal.talinterpreter, line 513, in no_tag
  Module zope.tal.talinterpreter, line 343, in interpret
  Module zope.tal.talinterpreter, line 858, in do_defineMacro
  Module zope.tal.talinterpreter, line 343, in interpret
  Module zope.tal.talinterpreter, line 954, in do_defineSlot
  Module zope.tal.talinterpreter, line 343, in interpret
  Module zope.tal.talinterpreter, line 533, in do_optTag_tal
  Module zope.tal.talinterpreter, line 518, in do_optTag
  Module zope.tal.talinterpreter, line 513, in no_tag
  Module zope.tal.talinterpreter, line 343, in interpret
  Module zope.tal.talinterpreter, line 946, in do_defineSlot
  Module zope.tal.talinterpreter, line 343, in interpret
  Module zope.tal.talinterpreter, line 533, in do_optTag_tal
  Module zope.tal.talinterpreter, line 518, in do_optTag
  Module zope.tal.talinterpreter, line 513, in no_tag
  Module zope.tal.talinterpreter, line 343, in interpret
  Module zope.tal.talinterpreter, line 583, in do_setLocal_tal
  Module zope.tales.tales, line 696, in evaluate
   - URL: file:/Plone/buildout-cache/eggs/Products.CMFPlone-4.3-py2.6.egg/Products/CMFPlone/skins/plone_deprecated/sitemap.pt
   - Line 28, Column 8
   - Expression: <PathExpr nocall:u'context/@@sitemap_view'>
   - Names:
      {'container': <PloneSite at /plonesite>,
       'context': <PloneSite at /ploneiste>,
       'default': <object object at 0x7f5ba72404d0>,
       'here': <PloneSite at /plonesite>,
       'loop': {},
       'nothing': None,
       'options': {'args': ()},
       'repeat': <Products.PageTemplates.Expressions.SafeMapping object at 0x98baf70>,
       'request': <HTTPRequest, URL=https://myserver/plonesite/sitemap>,
       'root': <Application at >,
       'template': <FSPageTemplate at /plonesite/sitemap>,
       'traverse_subpath': [],
       'user': <PropertiedUser 'user'>}
  Module zope.tales.expressions, line 217, in __call__
  Module Products.PageTemplates.Expressions, line 147, in _eval
  Module zope.tales.expressions, line 124, in _eval
  Module Products.PageTemplates.Expressions, line 74, in boboAwareZopeTraverse
  Module OFS.Traversable, line 317, in restrictedTraverse
  Module OFS.Traversable, line 300, in unrestrictedTraverse
   - __traceback_info__: ([], '@@sitemap_view')
AttributeError: @@sitemap_view

Change History

comment:1 Changed 3 years ago by kleist

  • Keywords migration traceback removed
  • Status changed from new to confirmed
  • Component changed from Unknown to Upgrade/Migration
  • Description modified (diff)
  • Priority changed from minor to major

Wrapped traceback in triple curly brackets.

comment:2 Changed 3 years ago by danjacka

Two workarounds to try:

  1. plone_deprecated skin layer is not enabled in 4.3 ( https://github.com/plone/Products.CMFPlone/commit/90d9ab4e1957fa206cf5ea2d602d691d2ac22c58). What happens if you disable that skin layer in your upgraded site?
  1. @@sitemap_view is renamed to @@sitemap in 4.3 ( https://github.com/plone/Products.CMFPlone/commit/6fb1c011e27bc54d1511749517990877e1adee91). Try overriding plone_deprecated/sitemap.pt to call the new view instead.
Last edited 3 years ago by danjacka (previous) (diff)

comment:3 Changed 3 years ago by AbimAbam

Tried both (1,2), both work.

Thank you.

I'll stay with 1.

Last edited 3 years ago by AbimAbam (previous) (diff)

comment:4 Changed 3 years ago by dholth

I had the same irritating problem.

skins/plone_deprecated/sitemap.pt [and other views that are now also provided by non-plone_deprecated browser views] should be deleted.

$ diff skins/plone_deprecated/sitemap.pt browser/templates/sitemap.pt 
29,30c29
<             class="navTreeLevel0 visualNoMarker"
<             tal:define="view nocall:context/@@sitemap_view;">
---
>             class="navTreeLevel0 visualNoMarker">

comment:5 Changed 2 years ago by frisi

i removed the plone_deprecated layer for all skin selections in an upgrade step of my policy package.

could we use the same code for the upgrade stop from plone 4.3.2 to 4.3.3 so this is fixe in the next plone version?

    ps = portal.portal_skins
    selections = ps._getSelections()
    for selection in ps.getSkinSelections():
        oldLayers = selections[selection]
        selections[selection] = oldLayers.replace('plone_deprecated,','')
Note: See TracTickets for help on using tickets.