Ticket #10123 (confirmed Feature Request)

Opened 6 years ago

Last modified 3 years ago

ATNewsItem should be supported by plone.app.blob

Reported by: MichaelHierweck Owned by:
Priority: minor Milestone: 4.x
Component: General Version: 4.2
Keywords: NewsItem, blobs, patch Cc: keul

Description

ATNewsItem contains an image field which should be supported by plone.app.blob.

I'm not sure whether this

  • is a bug because the missing support for ATNewsItem is a *mistake*
  • is a feature request because support for ATNewsItem would be *new*
  • is missing for some good reason.

I tried to find out on the mailing list and on IRC but did not get any response.

Change History

comment:1 in reply to: ↑ description Changed 6 years ago by witsch

  • Owner nouri deleted
  • Component changed from Archetypes to Infrastructure
  • Type changed from Bug to Feature Request
  • Milestone changed from 4.0 to 4.x

Replying to MichaelHierweck:

ATNewsItem contains an image field which should be supported by plone.app.blob.

yes, that would make sense in terms of consistency, of course.

I'm not sure whether this

  • is a bug because the missing support for ATNewsItem is a *mistake*
  • is a feature request because support for ATNewsItem would be *new*
  • is missing for some good reason.

it's rather an oversight than a mistake, but there's no real reason for not having it. so i'd vote for "nice to have"... :) seriously though, i think it'd be great to get those images converted as well, but it might be a bit late in the process. and even apart from that, this was never part of the original PLIP, so even formally it should better be deferred to 4.1 or later...

would you mind setting up a PLIP ticket for this, or turning this into one for that matter?

btw, if you prefix the "*" with a space, you'll get a proper list and won't need the [[BR]] ;)

I tried to find out on the mailing list and on IRC but did not get any response.

huh, do you have a url for that posting? or alternatively, the list & subject?

comment:2 Changed 6 years ago by witsch

  • Keywords blobs added; Blob removed

adjusting the keywords so they match my blob ticket query... :)

comment:3 Changed 6 years ago by witsch

fyi, convenience base classes for file and image fields have been added in r35476 & should make this undertaking a little more straight-forward...

comment:4 Changed 4 years ago by davisagli

  • Component changed from Infrastructure to General

comment:5 Changed 4 years ago by kleist

  • Status changed from new to confirmed
  • Version set to 4.0

comment:6 Changed 4 years ago by keul

  • Cc keul added
  • Version changed from 4.0 to 4.2

I was not aware of this ticket, I have a pretty new pull request about this:  https://github.com/plone/plone.app.blob/pull/2

I don't know if the way I took is good.

comment:7 Changed 3 years ago by kleist

  • Keywords blobs, patch added; blobs removed

comment:8 Changed 3 years ago by keul

Added a pull request also for plone.app.upgrade (as required from the plone-developers mailing list).

 https://github.com/plone/plone.app.upgrade/pull/5

comment:9 Changed 3 years ago by pbauer

Just in case this gets accepted at some point, there is a migration-step in plone.app.contenttypes to also migrate blob-bases ATNewsItems to dexterity.

Note: See TracTickets for help on using tickets.