Ticket #11021 (closed PLIP: wontfix)

Opened 6 years ago

Last modified 6 years ago

Simple theming customizations through the plone interface

Reported by: robzonenet Owned by: robzonenet
Priority: minor Milestone: 4.1
Component: Unknown Version:
Keywords: Cc: plip-advisories@…

Description (last modified by limi) (diff)

Proposer: Rob Porter
Seconder: Alexander Limi

Motivation

Simple customizations to a Plone site's design require the user to delve into the ZMI or create a filesystem product. This PLIP aims to bring the ability to do CSS and JavaScript customizations and logo upload/replacement through Plone's "Themes" control panel.

Assumptions

  1. The ZMI scares new users
  2. Simple theme customization is one of the first tasks involved in evaluating/setting up a site
  3. Plone 4.0's stock themes have abandoned the use of base_properties; so variable-dependent add-ons like CSSManager no longer provide the ability to change designs "through-the-Plone".

Proposal & Implementation

Implementation will include new sections of the existing Theme control panel. Textareas will be provided to serve as proxies for the existing ploneCustom.css and a new ploneCustom.js. Editing each of these would place the customizations in the relevant files in portal_skins' "custom" folder. Similarly, a file field will allow modifications to logo.jpg

Deliverables

New code will include:

  • Additions to plone.app.controlpanel's skins.py

Migrations needed:

  • Adding ploneCustom.js to existing sites
  • Unit tests
  • Localization
  • Documentation

Risks

collective.controlpanel.edit_css provides similar functionality. Sites already using this may have inconsistencies.

Participants

Rob Porter (robzonenet)

Progress

None yet.

Change History

comment:1 Changed 6 years ago by limi

  • Description modified (diff)

Adding myself as seconder, fixing some markup.

comment:2 Changed 6 years ago by limi

  • Description modified (diff)

comment:3 Changed 6 years ago by robgietema

I'm not sure we should encourage people to theme a plone-site like this. Our theming story is already pretty hard to understand for most integrators since we have all these different options (zmi, on filesystem, using xdv, deliverance) adding yet another method will make things even more complicated.

comment:4 Changed 6 years ago by ldr

FWT's view was to make this an add-on for 4.1 and consider again for 4.2. We definitely want to avoid exposing dtml to users.

comment:5 Changed 6 years ago by cah190

  • Cc plip-advisories@… added

comment:6 Changed 6 years ago by esteele

  • Status changed from new to closed
  • Resolution set to wontfix

This PLIP has been declined for consideration for Plone 4.1.

Framework Team voting on this PLIP was:

Alec -1 Craig -1 Elizabeth -1 Laurence -1 Martijn -1 Matthew -1 Rob -1 Ross -

The Framework Team did not support the proposed implementation. They've recommended that the fields be rendered directly as resources, rather than as proxies for dtml documents. They've asked that you continue to develop this as an add-on and resubmit for a later release.

Note: See TracTickets for help on using tickets.