Ticket #10846 (closed PLIP: fixed)

Opened 6 years ago

Last modified 5 years ago

Include plone.testing and plone.app.testing in KGS

Reported by: optilude Owned by: optilude
Priority: minor Milestone: 4.1
Component: General Version:
Keywords: Cc: plip-advisories@…

Description (last modified by optilude) (diff)

Motivation

ZopeTestCase and PloneTestCase have grown organically to the point where they are difficult to use effectively. Very few people fully understand the fixture they set up, and they are not very well documented.

plone.testing and plone.app.testing aim to address this with a clean, well-documented framework based on layers. They are currently released as alpha versions, although they are relatively stable.

Assumptions

N/A

Proposal & Implementation

  • Add plone.testing and plone.app.testing to our KGS so that they can be used
  • Encourage new packages to use these frameworks instead of ZTC/PTC (this may apply to new packages written for Plone 4.1)

Porting existing tests to these new frameworks is explicitly out of scope.

Deliverables

  • KGS updates
  • Documentation updates

Risks

If plone.testing/plone.app.testing doesn't work out in practice, we'll look like ass-clowns.

Participants

Martin Aspeli, and hopefully others :-)

Progress

  • plone.testing 1.0a1 released
  • plone.app.testing 1.0a1 released

Change History

comment:1 Changed 6 years ago by optilude

  • Description modified (diff)

comment:2 Changed 6 years ago by ldr

+1 Having used plone.testing for plone.subrequest it does seem sane and comes with excellent documentation.

comment:3 Changed 6 years ago by esteele

Your PLIP has been accepted for consideration for Plone 4.1.

Framework Team voting on this PLIP was: Alec +1 Craig +1 Elizabeth +1 Laurence +1 Martijn +1 Matthew +1 Rob +1 Ross +1

The initial implementation deadline for your PLIP is October 1st, 2010. The Framework Team would certainly appreciate you finishing beforehand so that they may begin evaluating it as soon as possible. Announce its readiness here once your implementation is ready for review.

comment:4 Changed 6 years ago by optilude

Framework team -

I'm not sure what is really required for this other than just update the versions.cfg in the buildout? If so, I'd rather just do that straight on the 4.1 branch, rather than making a silly branch with a two-line change. Is that OK?

Martin

comment:5 Changed 6 years ago by optilude

  • Owner set to optilude

comment:6 Changed 6 years ago by optilude

The buildout for #9472 and #9473 (plips/plip9472-9473-registry-z3cform.cfg) now includes plone.app.testing as a dependency. This can be used to run the plone.testing and plone.app.testing tests. plone.app.registry now uses plone.app.testing for its own tests.

comment:7 Changed 6 years ago by optilude

As per r39259, plone.uuid now uses plone.app.testing for test setup. See also #10778.

comment:8 Changed 6 years ago by robgietema

Added review r40086

comment:9 Changed 6 years ago by cah190

  • Cc plip-advisories@… added

comment:10 Changed 6 years ago by cah190

(In [40353]) Review for PLIP 10846. Refs #10846.

comment:11 Changed 5 years ago by esteele

(In [46244]) Merge in (related) PLIPs. Refs #9472. Refs #9473. Refs #10846.

comment:12 Changed 5 years ago by esteele

  • Status changed from new to closed
  • Resolution set to fixed

comment:13 Changed 4 years ago by davisagli

  • Component changed from Infrastructure to General
Note: See TracTickets for help on using tickets.