Ticket #13358 (confirmed PLIP)

Opened 3 years ago

Last modified 17 months ago

Remove layout table from unstyled plone.

Reported by: THijs Owned by: THijs
Priority: minor Milestone: 5.0
Component: Templates/CSS Version: 4.2
Keywords: Cc: vangheem, THijs, spereverde

Description (last modified by spereverde) (diff)

Proposer: THijs (TH-code) Seconder: Nathan Van Gheem, Kim Paulissen (spereverde)

Motivation
Layout tables have been considered wrong for a long time now. Since plone is unstyled in the Default plonetheme, it does not make sense to keep the layout table in. The base theme should have a sane default.

The unstyled theme is the basis for Diazo themes. Having the table still in the markup will only make it easier to maybe mistakenly or unknowingly copy it over into the styled markup.

Implementation
Add the main_template from CMFPlone (with table layout) to the plonetheme.classic and turn the main_template in CMFPlone into div's.

 https://github.com/plone/Products.CMFPlone/tree/plip13358  https://github.com/plone/plonetheme.classic/tree/plip13358

Change History

comment:1 Changed 3 years ago by THijs

  • Component changed from Unknown to Templates/CSS
  • Type changed from Bug to PLIP

comment:2 Changed 3 years ago by davisagli

When you select "PLIP" as the ticket type trac is supposed to prompt you to use a template of the various info that should be provided for a PLIP. Is it not doing that?

comment:3 Changed 3 years ago by THijs

Proposer: THijs (TH-code) Seconder:

Motivation
Layout tables have been considered wrong for a long time now. Since plone is unstyled in the Default plonetheme, it does not make sense to keep the layout table in. The base theme should have a sane default.

The unstyled theme is the basis for Diazo themes. Having the table still in the markup will only make it easier to maybe mistakenly or unknowingly copy it over into the styled markup.

Implementation
Add the main_template from CMFPlone (with table layout) to the plonetheme.classic and turn the main_template in CMFPlone into div's.

 https://github.com/plone/Products.CMFPlone/tree/plip13358  https://github.com/plone/plonetheme.classic/tree/plip13358

comment:4 Changed 3 years ago by THijs

Hi David,

No it's not doing that, I've been formatting it by hand to resemble other plips.

I made my first two plips yesterday and today. It mentioned that it should on the plip page, but it did not work for the first (#13355). I figured it was because I filled in the description and should have waited for that. So today I tried without, but that still did not work.

Last edited 3 years ago by THijs (previous) (diff)

comment:5 Changed 3 years ago by vangheem

  • Status changed from new to confirmed
  • Description modified (diff)

comment:6 Changed 3 years ago by vangheem

  • Cc vangheem added

comment:7 Changed 3 years ago by THijs

  • Cc THijs added

comment:8 Changed 3 years ago by spereverde

  • Cc spereverde added
  • Description modified (diff)

comment:9 Changed 3 years ago by thet

sounds good. so, you'd copy the plonetheme.sunburst's main_template back to Products.CMFPlone? then we would need some styles in the plone_styles skin layer, which do the columns formating.

IMO, we could drop the dependency on plonetheme.classic in Plone 4.4. plonetheme.sunburst is the new default theme - the classic is just for backwards compatibility and can be explicitly included by projects, which need it.

comment:10 Changed 3 years ago by THijs

I have copied over the template from Products.CMFPlone into plonetheme.classic and then converted the table into a div structure. Moving over the template from sunburst would also have to include the deco grid system and browserviews from sunburst. Which I think should probably not be there. Since it is the unstyled theme of Plone I would also say we do not need styles for the columns formatting. You would do this in Diazo or whatever theme you base on "Plone Default".

I was under the impression that removing plonetheme.classic still lead to breakage in several products. It is also the one theme that still shows us how to do DHTML. For people getting into Plone it might still serve a purpose in that. I know theming has moved away from DHTML, but without the use of CSS preprocessors it is still very practical if you have to do css with variables.

comment:11 Changed 3 years ago by THijs

The 4.4 branch has been cut, so I've implemented these changes in the Products.CMFPlone master branch (4.4.a):

  • Changed table layout to div structure identical to sunburst
    • Removed xml:lang on html tag
    • Changed charset to html5
    • Removed deprecated css-slot
    • Removed old-style corner constructs

In plonetheme.classic master (1.3.2):

  • Added a classic_templates skin folder
  • Added the old main_template.pt with table layout in classic_templates
  • Updated profiles and configure.zcml

comment:12 Changed 3 years ago by davisagli

THijs, the usual process for PLIPs is to implement them on branches, then have the framework team review the changes before they get merged to master. However I looked over your changes and they make sense to me, and I'm happy to have someone working on cleaning up these templates, so it's probably not worth getting too formal about process. Thank you.

comment:13 Changed 3 years ago by esteele

  • Milestone changed from 4.x to 5.0

The Framework Team has decided to move on to Plone 5. Updating milestones accordingly.

comment:14 Changed 17 months ago by ramon

Its been implemented on the plone5 main_template PLIP, is it ok to close this PLIP ?

comment:15 Changed 17 months ago by THijs

Should be okay if that template is used for the unstyled plone theme?

Note: See TracTickets for help on using tickets.