Ticket #12092 (confirmed Bug)
Accessibility improvements to default Plone folder views
Reported by: | trs22 | Owned by: | rmattb |
---|---|---|---|
Priority: | minor | Milestone: | 5.0 |
Component: | Templates/CSS | Version: | 4.3 |
Keywords: | accessibility | Cc: | trs22, rmattb |
Description (last modified by rmattb) (diff)
The folder_summary_view uses h2 and p tags as the item titles and descriptions:
while the folder_listing view uses dl and dt and dd tags:
There needs to be a discussion around if the h2's in folder_summary_view are semantically correct as headers, versus the dl/dt/dd implementation in folder_listing. When we discussed this, there wasn't a clear consensus on if headers made sense, but we did have a consensus that both should be implemented consistently.
This will probably break a *bunch* of individual themes CSS no matter how it changes.
Change History
comment:1 Changed 5 years ago by rmattb
- Component changed from Infrastructure to Templates/CSS
- Milestone set to 4.2
comment:4 in reply to: ↑ description ; follow-up: ↓ 11 Changed 5 years ago by rmattb
The folder_tabular_view should use <th> tags for the item titles in the first column, instead of <td>.
comment:5 in reply to: ↑ description Changed 5 years ago by rmattb
- Description modified (diff)
Replying to trs22:
The folder_summary_view uses h2/p tags as the item titles and descriptions:
while the folder_listing view uses dl/dt/dd:
There needs to be a discussion around if the h2's in folder_summary_view are semantically correct as headers, versus the dl/dt/dd implementation in folder_listing. When we discussed this, there wasn't a clear consensus on if headers made sense, but we did have a consensus that both should be implemented consistently.
This will probably break a *bunch* of individual themes CSS no matter how it changes.
comment:6 Changed 5 years ago by rmattb
- Description modified (diff)
The atct_album_view should also use heading tags.
comment:9 Changed 5 years ago by rmattb
- Description modified (diff)
- Summary changed from Accessibility enhancements to default Plone folder views (folder_listing, folder_summary_view) to Accessibility improvements to default Plone folder views
comment:10 in reply to: ↑ 7 Changed 5 years ago by rmattb
Adding a heading tag <h2> inside the definition term tag <dt> fails validation, because h2 is a block level element, and dt is inline.
This problem is similar to that of heading tags on portlet headings, #11978.
comment:11 in reply to: ↑ 4 Changed 5 years ago by rmattb
Replying to rmattb:
The folder_tabular_view should use <th> tags for the item titles in the first column, instead of <td>.
The table header tag should also specify the row as its scope: <th scope="row">
comment:12 Changed 4 years ago by rmattb
The best solution for the folder_listing view's definition lists is to change the definition list to headings and paragraphs. See https://weblion.psu.edu/trac/weblion/changeset/17477
comment:13 Changed 4 years ago by rmattb
- Version set to 4.1
Code for this in Plone 4.1 has been tested with JAWS, VoiceOver, and NVDA is at https://weblion.psu.edu/trac/weblion/browser/weblion/plonetheme.psuaccessiblesunburst/
Specifically, these changesets for the non-tabular views:
Specifically, these changesets for the tabular view:
comment:15 Changed 4 years ago by rmattb
- Version changed from 4.1 to 4.3
- Milestone changed from 4.2 to 4.3
comment:17 Changed 4 years ago by rmattb
For new Plone 4.2 collections:
Standard view:
https://weblion.psu.edu/trac/weblion/changeset/17569/weblion/plonetheme.psuaccessiblesunburst/trunk/plonetheme/psuaccessiblesunburst
https://weblion.psu.edu/trac/weblion/changeset/17570/weblion/plonetheme.psuaccessiblesunburst/trunk/plonetheme/psuaccessiblesunburst
comment:18 follow-up: ↓ 19 Changed 3 years ago by kleist
Plone 4.3 b1 is round the corner, so if nothing has happened regarding this ticket I'd like to change its Milestone.
comment:19 in reply to: ↑ 18 Changed 3 years ago by rmattb
Replying to kleist:
Plone 4.3 b1 is round the corner, so if nothing has happened regarding this ticket I'd like to change its Milestone.
Yes, thank you.
comment:22 Changed 3 years ago by rmattb
Changed milestone to next major version, due to theming backward incompatibility.
Considerations for users of screen readers:
Therefore, people using screen readers are best served by the titles being tagged as headings.