Ticket #12456 (confirmed Bug)
plone.app.discussion comment.notify_user comment.user_notification always none!
Reported by: | trozki | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | 4.x |
Component: | Commenting/Discussion | Version: | 4.1 |
Keywords: | patch | Cc: |
Description
If user_notification setting is enabled and the user who comments selects the "notify me about new comments" checkbox an email should be sent. This fails.
If u insert in plone.app.discussion.comment at line 280 you can see that always comment.user_notification is None! :
if (comment.user_notification): logger.warn('comment.user_notification exists') else: logger.warn('comment.user_notification does not exist')
Change History
comment:1 Changed 4 years ago by trozki
- Summary changed from plone.app.discussion comment.notify user always none! to plone.app.discussion comment.notify_user comment.user_notification always none!
comment:2 Changed 4 years ago by trozki
o.k. I think we need more information about this bug.
my plone version is the newest stable : Plone 4.1.3
One of the developers in plone-irc already reproduced this bug. Please reproduce and review the behaivior of plone.app.discussion comment.notify_user ! In my opinion the "notify me" checkbox is never set! (I searched all sources for assignemnt. nothing found!)
This is my first bug upped to this comunity, if I misplaced it, please place it where it has to be. Don't know which component to assign to it ..
comment:3 Changed 4 years ago by kleist
- Keywords plone.app.discussionuser_notification added; plone.app.discussion user_notification removed
- Status changed from new to confirmed
- Version set to 4.1
- Component changed from Unknown to General
- Milestone set to 4.x
trotzki: you've done everything right, thanks! it's just that we're pretty short of resources :-[
comment:4 Changed 4 years ago by kleist
- Keywords plone.app.discussion, user_notification added; plone.app.discussionuser_notification removed
Using 4.3 coredev buildout, I can confirm that ticking "Notify me of new comments via email." does not seem to work.
I have verified that toggling "Enable user email notification" on @@discussion-settings actually modifies the corresponding configuration registry record "plone.app.discussion.interfaces.IDiscussionSettings.user_notification_enabled".
So maybe the bug is buried somewhere here:
comment:5 Changed 4 years ago by damilgra
In the referenced file, the code looks correct, however in released versions of plone.app.discussion up to and including 2.20, a comment's user_notification will always be set to None.
Inserting the following two lines of code in the browser/comments.py at line 169 fixes the problem for me:
if 'user_notification' in data: user_notification = data['user_notification']
comment:6 Changed 4 years ago by kleist
- Keywords patch added; plone.app.discussion, user_notification removed
- Component changed from General to Commenting/Discussion
comment:7 Changed 3 years ago by mekell
AFIK the fix mentioned in #12834 has not yet been merged with Plone (up to 4.2.4).
Plone 4.2.4 is still using plone.app.discussion-2.1.8-py2.7.egg. Therefore this bug exists up to Plone 4.2.4.
Any idea when a new version of plone.app.discussion will find his way to Plone 4.2.# or 4.3?
Or can anybody describe a workaround to add a working version (e.g. v 2.2.3) of plone.app.discussion to the buildout of Plone 4.2.4?