Ticket #10476 (confirmed Bug)

Opened 6 years ago

Last modified 3 years ago

Folder full view is not XHTML-well formed (ids are not unique)

Reported by: dmunicio Owned by: elro
Priority: major Milestone: 4.x
Component: Templates/CSS Version: 4.2
Keywords: Cc:

Description

In folder_full_view, following ids are repeated for each element in the folder: plone-document-byline content-history parent-fieldname-title

so the page fails to comply with XHTML syntax

Change History

comment:1 Changed 6 years ago by dmunicio

It happens in Plone 4.0b2

comment:2 Changed 6 years ago by davisagli

  • Owner set to elro

comment:3 Changed 6 years ago by hannosch

  • Priority changed from minor to major

Still happens. This is rather hard to fix, as the "all content view" just renders all the items. So we need to convert all ids to use classes and write tests to make sure nobody adds CSS ids inside the content area in the future.

comment:4 Changed 6 years ago by hannosch

  • Milestone changed from 4.0 to 4.1

On second thought, those changes are too big to do in 4.0 now or a 4.0.x bug fix release. /me grumbles at this new view not having had a PLIP and a review

comment:5 Changed 5 years ago by cwainwright

Confirmed this is still an issue in Plone 4.1 (4109) and 4.2 (4201)

comment:6 Changed 4 years ago by kleist

  • Status changed from new to confirmed
  • Version set to 4.2

Is this still important in 4.2, now that we serve HTML5?

comment:7 Changed 3 years ago by vangheem

I'm not sure how important this is but not duplicating ids is still part of the HTML5 spec. The problem is that if we change those ids to classes, it might break themes.

I think it's reasonable to fix this before 4.3 is released IMO. Might not be worth it though.

It's just unfortunate that the way one view is done would cause a few different packages to need fixes and possibly break themes. I'm tempted to just suggest not fixing it though since all browsers render the page fine with duplicate ids.

Note: See TracTickets for help on using tickets.