Ticket #11697 (closed PLIP: please review)

Opened 5 years ago

Last modified 5 years ago

All authorinfo links opened in an overlay

Reported by: thomasdesvenain Owned by: limi
Priority: minor Milestone: 4.2
Component: User Experience and Interface Version:
Keywords: users, document, ui Cc: vincentfretin, ggozad

Description (last modified by thomasdesvenain) (diff)

Proposer: Thomas Desvenain
Seconder: Vincent Fretin

Motivation

In most cases, when she clicks on author home link, (on document by line, on folder listing, etc) user doesn't really want to change the page she's reading.

Opening author profile page in an overlay would be better for user experience.

This behaviour would be more consistent with overlay-opened historyview page.

Assumptions

  • Author home in document by line viewlet
  • Author links on folder_listing
  • Author links on folder_tabular_view

Proposal & Implementation

1rst proposal :

  • An 'author-overlay' class may be added to <a> elements of views listed before.
  • A prepOverlay on "a.author-overlay" elts should be added in ./Products/CMFPlone/skins/plone_ecmascript/popupforms.js ?

2nd proposal :

  • In popupforms.js, make 'prepOverlay' on <a> elements whose href is like */author/[/]* and

Deliverables

1rst proposal : Changes to be made on Products.CMFPlone, plone.app.layout 2nd proposal : Change only in popupforms.js in Products.CMFPlone

Risks

  • link-overlay should'nt be dotted, as #content a.link-overlay public.css rule do
  • no overlay in user prefs pages
  • check author view in overlay remains good-looking

Participants

Thomas Desvenain [thomasdesvenain]

Progress

Tested on specific code, but no industrialized code done yet

Change History

comment:1 Changed 5 years ago by thomasdesvenain

  • Description modified (diff)

comment:2 Changed 5 years ago by mj

The framework team would definitely like to see option 1 implemented (explicit class on links).

We'd like to see this in 4.2, so do go ahead and implement this (on a branch). Please keep the ticket updated on your progress, and I'll review the changes.

comment:3 Changed 5 years ago by mj

We have a feature freeze set for June 30th. If you want this PLIP to be part of Plone 4.2, you'll need to have an implementation ready for review ASAP (we need time to review and provide feedback, and you may want to have time to respond and adjust).

Feel free to mark this ticket as Milestone 4.x instead to indicate that you won't be able to implement this for 4.2. :-)

comment:4 Changed 5 years ago by thomasdesvenain

(In [50288]) Links to authors are opened in an overlay. refs #11697

comment:5 Changed 5 years ago by thomasdesvenain

(In [50289]) Links to authors are opened in an overlay. refs #11697

comment:6 Changed 5 years ago by thomasdesvenain

  • Status changed from new to closed
  • Resolution set to please review

PLIP is ready for review

  • link-overlay should'nt be dotted, as #content a.link-overlay public.css rule do

I'm not sure right now. history link is dotted, why not user link ?

For better ui behaviour of feedback_form  http://dev.plone.org/plone/ticket/11902 have to be fixed

comment:7 Changed 5 years ago by mj

Can you elaborate a little more about the UI behaviour of the feedback form?

Is the feedback form broken when loaded in an overlay right now because it is optional?

comment:8 Changed 5 years ago by ggozad

  • Cc ggozad added

comment:9 follow-up: ↓ 11 Changed 5 years ago by thomasdesvenain

i could'nt use the ajax handling of the feedback form with formselector option, because then, overlay is broken when there is no feedback for on author view (e.g. when an user clicks on its own profile)

comment:10 Changed 5 years ago by thomasdesvenain

that's related to this ticket i have added but i could'nt fix :  http://dev.plone.org/plone/ticket/11902

comment:11 in reply to: ↑ 9 Changed 5 years ago by mj

Replying to thomasdesvenain:

i could'nt use the ajax handling of the feedback form with formselector option, because then, overlay is broken when there is no feedback for on author view (e.g. when an user clicks on its own profile)

Thanks, it's the 'own profile' detail that was important. I'll see whom we can poke to think about that issue.

comment:12 Changed 5 years ago by ggozad

Hey, some remarks before reviewing this properly:

  • I would prefer to see less information inside the overlay, potentially also avoiding the problems you mention with the form. In other words, the overlay can present the basic user info (id, fullname, portrait) and link to the full profile where the list of content created by the user together with the contact form can be shown if appropriate.
  • If you choose to to ignore the above, then after using the contact form I would expect to return to the content. Instead I go back to the contact form where I can see the status message indicating the mail was sent.

comment:13 Changed 5 years ago by thomasdesvenain

I would prefer to see less information inside the overlay...

I agree, but I think this have to be the subject of an other plip.

If you choose to to ignore the above, then after using the contact form I would expect to return to the content. Instead I go back to the contact form where I can see the status message indicating the mail was sent.

Because of the bug  http://dev.plone.org/plone/ticket/11902, this is not possible without very ugly code. Whereas if this bug is fixed, this can be done naturally.

comment:14 Changed 5 years ago by robgietema

(In [50592]) Added review. refs #11697

comment:15 Changed 5 years ago by ggozad

(In [50672]) Review for PLIP 11697 Author info overlay. Refs #11697

comment:16 Changed 5 years ago by thomasdesvenain

Regarding that UI team doesn't agree with the goal of the PLIP itself (no overlay for read only users) and that some comments have an heavy impact on ui behaviour and would modify the PLIP (not the same content on author view and author overlay). I think it's better to abandon it.

Note: See TracTickets for help on using tickets.