Ticket #13747 (new Bug)
Opened 3 years ago
Error when changing diazo theme in plone.app.theming
Reported by: | frederic.brun@… | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 4.x |
Component: | Unknown | Version: | 4.3 |
Keywords: | diazo, theming | Cc: |
Description
I find a possible issue in src/plone/app/theming/utils.py, for the call of plugin.onEnabled : The parameters passed in plugin.onEnabled is the old currentTheme and not the one i choose.
I replace the 491 line : plugin.onEnabled(theme, pluginSettings[name], pluginSettings)
by : new_themeDirectory = queryResourceDirectory(
THEME_RESOURCE_NAME, theme)
if new_themeDirectory is not None:
plugins = getPlugins() new_pluginSettings = getPluginSettings(new_themeDirectory, plugins) if new_pluginSettings is not None:
for name, plugin in plugins:
plugin.onEnabled(theme, new_pluginSettings[name], new_pluginSettings)
I've made a request on https://github.com/plone/plone.app.theming/pulls