Ticket #20332 (new Bug)

Opened 4 months ago

prepOverlay overwrites existing rel="" values

Reported by: uschwarz Owned by: vangheem
Priority: minor Milestone: 4.x
Component: JavaScript Version: 4.3
Keywords: Cc:

Description

p.a.jquerytools' prepOverlay will overwrite the rel attribute on links it activates, replacing it with #pb_1, #pb_2 etc.

I can see the need for having the number somewhere, but one of the consequences is that having "Use popup forms" on means links like /login lose their rel="nofollow noindex".

To a zeroth approximation,

o.attr('rel', function(i, val){ return (val? val+' ':)+'#'+pbo.nt; });

instead of

o.attr('rel', '#' + pbo.nt);

as l.129 in overlayhelpers.js seems to fix this issue, but I've not found places that actually use the #pb value.

A similar case exists slightly earlier, for subtype inline.

Note: See TracTickets for help on using tickets.